Wizard: Fix password validation ignoring Azure character rules - #4729
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4729 +/- ##
==========================================
+ Coverage 72.90% 77.92% +5.01%
==========================================
Files 261 264 +3
Lines 7043 7072 +29
Branches 2596 2599 +3
==========================================
+ Hits 5135 5511 +376
+ Misses 1880 1460 -420
- Partials 28 101 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 74 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new Azure-specific
isValidcondition (isLengthValid && (!isAzure || rulesCount >= 3)) is quite compact; consider extracting therulesCount >= 3requirement into a named constant or helper to make the Azure password policy more explicit and reusable. - Most of the changes outside
checkPasswordValidityare union-type formatting adjustments; you may want to split these stylistic updates into a separate PR to keep this one focused on the Azure password validation fix.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new Azure-specific `isValid` condition (`isLengthValid && (!isAzure || rulesCount >= 3)`) is quite compact; consider extracting the `rulesCount >= 3` requirement into a named constant or helper to make the Azure password policy more explicit and reusable.
- Most of the changes outside `checkPasswordValidity` are union-type formatting adjustments; you may want to split these stylistic updates into a separate PR to keep this one focused on the Azure password validation fix.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The isValid check only verified password length, ignoring the requirement for at least 3 character types (lowercase, uppercase, numbers, symbols) when Azure is selected as a target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isValid check only verified password length, ignoring the
requirement for at least 3 character types (lowercase, uppercase,
numbers, symbols) when Azure is selected as a target.